PolymerElements / paper-dropdown-menu

A Material Design browser select element
https://www.webcomponents.org/element/PolymerElements/paper-dropdown-menu
61 stars 107 forks source link

port to 2.0 #203

Closed valdrinkoshi closed 7 years ago

valdrinkoshi commented 7 years ago

Port to Polymer 2.0

googlebot commented 7 years ago

So there's good news and bad news.

:thumbsup: The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

:confused: The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

notwaldorf commented 7 years ago

Shady dom demo looks a bit busted:

screen shot 2017-04-13 at 2 35 06

Edit: busted in shadow DOM in the same way too.

Also, selection doesn't work

valdrinkoshi commented 7 years ago

@notwaldorf re broken selection: it happens because animations are broken https://github.com/web-animations/web-animations-js/issues/123 re correct rendering: doesn't happen with the latest releases of polymer rc.4 / webcomponentsjs rc.8 / shadycss rc.5 http://polygit.org/polymer+v2.0.0-rc.4/webcomponentsjs+webcomponents+v1.0.0-rc.8/shadycss+webcomponents+1.0.0-rc.5/paper*+polymerelements+:2.0-preview/iron*+polymerelements+:2.0-preview/app*+polymerelements+:2.0-preview/neon*+polymerelements+:2.0-preview/components/paper-dropdown-menu/demo/index.html (easier to try it locally)

notwaldorf commented 7 years ago

@valdrinkoshi ah, cool, confirmed