search

PolymerElements / paper-dropdown-menu

A Material Design browser select element
https://www.webcomponents.org/element/PolymerElements/paper-dropdown-menu
61 stars 107 forks source link

Remove polylint check #221

Closed limonte closed 7 years ago

limonte commented 7 years ago

polylint will always fail because of iron-icon package which uses the undocumented isAttached property and polylint does not handle it properly.

notwaldorf commented 7 years ago

Closing this; we should fix it in iron-icon not just remove polylint because it fails.

In the future, if you're going to send the same PR to multiple repos, please send only one and see what the feedback is on that, before reproducing it to other repos :)

limonte commented 7 years ago

we should fix it in iron-icon not just remove polylint because it fails.

iron-icon is totally fine, polylint should be fixed.

notwaldorf commented 7 years ago

Yes, is what I meant, and there's a PR open on polylint for that. I meant: iron-icon's polylint should pass, and we shouldn't disable random elements' polylint step because somewhere in a dependency there's a linting problem