search

PolymerElements / paper-dropdown-menu

A Material Design browser select element
https://www.webcomponents.org/element/PolymerElements/paper-dropdown-menu
61 stars 107 forks source link

Allow restoreFocusOnClose to be set on paper-dropdown-menu #227

Closed lesliana closed 7 years ago

lesliana commented 7 years ago

Paper-dropdown-menu creates a child paper-menu-button. Paper-menu-button has a restore-focus-on-close property, but there is currently no way for components with a paper-dropdown-menu to set this property. This will allow components with a paper-dropdown-menu to choose not to have focus set on the menu when the menu closes.

valdrinkoshi commented 7 years ago

LGTM provided tests are green 💚

valdrinkoshi commented 7 years ago

Polylint errors in travis... @rictic any idea on this one?

rictic commented 7 years ago

This is https://github.com/PolymerLabs/polylint/pull/149 (old linter).

I'll ping that PR again.

rictic commented 7 years ago

polylint updated and published, this PR lints clean now

valdrinkoshi commented 7 years ago

@lesliana I realize now that this property should have also been exposed by paper-dropdown-menu-light...mind doing a separate PR?

lesliana commented 7 years ago

Yes, I had thought about that and asked about it over chat before creating the pull request but didn't hear a response, so I figured I'd just go ahead with paper-dropdown-menu only. I created the new PR: https://github.com/PolymerElements/paper-dropdown-menu/pull/230.