search

PolymerElements / paper-dropdown-menu

A Material Design browser select element
https://www.webcomponents.org/element/PolymerElements/paper-dropdown-menu
61 stars 107 forks source link

from polymerelements to PolymerElements in 2.0-preview #243

Closed bartolom closed 7 years ago

bartolom commented 7 years ago

This pull request wants to make this Polymer element consistent with the majority of other Polymer elements in the 2.0-preview branch. The uppercase version "PolymerElements" is closer to real name of the github project name, like presented in the git URL.

The use of mixed case does not seem to have an effect on bower and JavaScript projects. But other languages like Java are more picky and would benefit from consistency.

I fixed this in the "2.0-preview" branch of this element, because it would be very nice to have this cleaned up and consistent in 2.0 release. I have manually checked 66 elements that have a "2.0-preview" branch. 56 are ok. This element is one of 10 which has these small differences.

This pull request is a manual follow up of PolymerLabs/tedium#47 and PolymerLabs/tedium#48 which try to do this in an automated way, but are stuck.

bartolom commented 7 years ago

Dear Valdrin Koshi

Thank you for looking into this.

I have created a pull request in the 1.x master branch as well in #244

I'm tracking the progress of all these changes in a comment with checkboxes in https://github.com/PolymerLabs/tedium/issues/47#issuecomment-271290694 and I'm hoping to get the 2.x and 1.x branches to be clean some time soon, when all the tiny pull reqests go through.

valdrinkoshi commented 7 years ago

Hi @bartolom, sorry for the confusion, I meant to ask to modify also line 54 (which is the "1.x" block in the bower.json).

valdrinkoshi commented 7 years ago

LGTM, will merge this anyways in 2.0-preview and resolve the conflicts in that branch 👌 Thanks for the contribution @bartolom !