Add 'ignoreSelect' - Githubissues

francisdaigle commented 6 years ago

Add option to disable automatic closing of dropdown after selection made by exposing paper-menu-button ignoreSelect.

Fixes #53, #171

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

francisdaigle commented 6 years ago

I signed it!

googlebot commented 6 years ago

CLAs look good, thanks!

jpradelle commented 6 years ago

I was about to do that PR the same way, this is really needed, can someone merge it ? There are several opened PR for the same need: https://github.com/PolymerElements/paper-dropdown-menu/pull/177 https://github.com/PolymerElements/paper-dropdown-menu/pull/186 https://github.com/PolymerElements/paper-dropdown-menu/pull/230 https://github.com/PolymerElements/paper-dropdown-menu/pull/255

googlebot commented 5 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

googlebot commented 5 years ago

CLAs look good, thanks!

PolymerElements / paper-dropdown-menu

Add 'ignoreSelect' #270