Open mgiuffrida opened 7 years ago
@mgiuffrida: paper-icon-button-light
lazily creates ripples. the lazily created ripple listens for the same events. so, if I understand correctly, the "dark" look is essentially double-handling events and double-showing partially opaque ripples.
I'm not sure this is intended.
Description
The
paper-icon-button
ripple when tapped (or activated via spacebar) is the same shade as its focus ripple.Expected outcome
The ripple should presumably be darker, to match
paper-button
as well aspaper-icon-button-light
.Actual outcome
The ripple is lighter than the other buttons' ripples. It doesn't differentiate between focus and pressing.
Live Demo
https://jsfiddle.net/37kmh427/
Steps to reproduce
paper-icon-button
; see light ripplepaper-icon-button-light
; see dark ripplepaper-button
; see dark rippleAlso:
paper-icon-button
; see light ripplepaper-button
; see no rippleAlso:
paper-icon-button
, then click and hold: ripple shimmerspaper-icon-button-light
orpaper-button
, then click and hold: solid ripple remains for duration of mouse press