PolymerElements / paper-icon-button

A Material Design icon button
https://www.webcomponents.org/element/PolymerElements/paper-icon-button
42 stars 44 forks source link

Doesn't work with polymer 2 #116

Closed anandanand84 closed 7 years ago

anandanand84 commented 7 years ago

Description

paper-icon-button shows no icon with polymer 2.0.

Expected outcome

An Icon is displayed

Actual outcome

No icon is displayed

Live Demo

https://github.com/anandanand84/polymer-icon-button-test

Steps to reproduce

  1. Create a new application using polymer init
  2. Import polymer-icon-button and add a paper-icon-button with icon=menu
  3. There wont be any icons visible.
web-padawan commented 7 years ago

You need to import corresponding icons separately, e. g. iron-icons (though I recommend creating your own iconset with only required icons instead).

anandanand84 commented 7 years ago

@web-padawan thank you. It does work after import iron-icons. But this line in the docs is misleading

paper-icon-button includes a default icon set. Use icon to specify which icon from the icon set to use.
notwaldorf commented 7 years ago

Ah yes, there's another issue about removing this line. Hold on, sending a PR

notwaldorf commented 7 years ago

Closed in #117