search

PolymerElements / paper-icon-button

A Material Design icon button
https://www.webcomponents.org/element/PolymerElements/paper-icon-button
42 stars 44 forks source link

Icon not showing up with Polymer 2.0 #129

Closed auguster closed 6 years ago

auguster commented 6 years ago

Description

Using an iron-icon from iron-icons with paper-icon-button using the icon attribute.

Expected outcome

The icon should be displayed.

Actual outcome

The icon doesn't show up. When using a custom icon with src attribute, it works.

Workaround

Import iron-icons directly in the paper-icon-button fix the issue.

adzadzadz commented 6 years ago

same issue, although I tried the workaround with v2.2.0, it's not working for me..

adzadzadz commented 6 years ago

Actually, it was working fine for me it's just that the background color #fff is the same as my paper-icon-button color.. Silly me haha

notwaldorf commented 6 years ago

i can't repro this: http://jsbin.com/javaxim/edit?html,output The documentation already says you must include an icon set (like iron-icons/iron-icons.html), and no default one is provided, so i think this is working as intended.

please re-open this if you have repro steps.

auguster commented 6 years ago

I confirm that it was a problem on our end. We had a mixed up in the versions between Polymer 1 and 2 because of a .bower.json (hidden) in our project.

Sorry for the issue, I'll try to make reproductible example next time, thanks for the link, I didn't know about Polygit ;-)

notwaldorf commented 6 years ago

No worries! Glad you sorted it out :)