PolymerElements / paper-icon-button

A Material Design icon button
https://www.webcomponents.org/element/PolymerElements/paper-icon-button
42 stars 44 forks source link

Make paper-ripple selector more specific #131

Open hcarmona opened 6 years ago

hcarmona commented 6 years ago

Fixes 130 by making the selector more specific

notwaldorf commented 6 years ago

I don't think this works; you can't target children of the distributed element (so nothing after the slotted( ). I've tried this patch locally, and I don't see the styles being applied.

While I'm trying to find a better fix, I think for now you have to style the paper-ripple at the point where you're distributing the button, so something like:

<custom-style>
  <style>
        paper-ripple {
          opacity: 0.6;
          color: red;
       }
  </style>
</custom-style>

<paper-icon-button-light>
  <button title="heart">
    <iron-icon icon="favorite"></iron-icon>
  </button>
</paper-icon-button-light>

/cc @kevinpschaaf

notwaldorf commented 6 years ago

I think there are only 2 choices available:

I'm leaning towards doing the default inherit, since that's probably what you need in 90% of cases.

WDYT?