PolymerElements / paper-icon-button

A Material Design icon button
https://www.webcomponents.org/element/PolymerElements/paper-icon-button
42 stars 44 forks source link

add alt attribute for a11y and fix double-tap event #18

Closed notwaldorf closed 9 years ago

notwaldorf commented 9 years ago
cdata commented 9 years ago

Since you've already done such a thorough job applying alt, I must do the evil thing and ask: is alt is the best name to use for this attribute? In other words, is it better to use alt than, say, title or label or something like that?

notwaldorf commented 9 years ago

I picked up alt because that's what Alice suggested in https://github.com/PolymerElements/paper-icon-button/issues/4. title is bad because it's used for tooltips (and tooltip != alt). Imgs have a native alt and it already has a fairly defined meaning (alternate text to be read), so it kind of make sense?

/cc @alice for input

alice commented 9 years ago

As per #4, alt is also what is used in input type=button for this purpose. As @notwaldorf points out, title has a different meaning and behaves differently. I think alt is correct.

alice commented 9 years ago

More info on alt for input: http://www.w3.org/TR/2012/WD-html5-20121025/states-of-the-type-attribute.html#attr-input-alt

notwaldorf commented 9 years ago

:wave: @cdata: also added the host attributes/behaviour change to fix https://github.com/PolymerElements/paper-icon-button/issues/19 like we talked about

notwaldorf commented 9 years ago

@cdata Fixed all the things. :eyeglasses: :8ball: :question:

cdata commented 9 years ago

LGTM :+1: