PolymerElements / paper-icon-button

A Material Design icon button
https://www.webcomponents.org/element/PolymerElements/paper-icon-button
42 stars 44 forks source link

Ripple gets cropped when not given an explicit height #38

Closed tjsavage closed 8 years ago

tjsavage commented 9 years ago

ripple

The ripple on paper-icon-button can get all funky with flexbox, and in a number of other contexts:

http://jsbin.com/yihezozaze/1/edit?html,console,output

ronnyroeller commented 8 years ago

+1

notwaldorf commented 8 years ago

I think this is working as intended. If you remove the flex, it behaves properly: http://jsbin.com/rifafe/edit?html,console,output. The flex should probably go on a container of the button, not the button itself (because you don't want to change the size of the button itself)