PolymerElements / paper-icon-button

A Material Design icon button
https://www.webcomponents.org/element/PolymerElements/paper-icon-button
42 stars 44 forks source link

Paper-icon-button stays in tapped state once tapped in ios9 #49

Closed mbergeron closed 8 years ago

mbergeron commented 8 years ago

Paper-icon-button stays in tapped state once tapped in ios9.

Picture comes from the Polymer demo page

image

kbwatts commented 8 years ago

+1

(Can also use toggles attribute to make it appear intentional, if that doesn't screw up your ux.)

notwaldorf commented 8 years ago

It doesn't stay toggled, that's the visual focus state (since the button is focused after clicking, and stays focused). On a desktop, if you tab to a button you'll see the same thing.

On mobile, I've noticed this happens for native a links as well: http://jsbin.com/gupica/edit?html,output, so I'm not sure it's a bug

kbwatts commented 8 years ago

You're right that the cause of this 'bug' is the :focus state which is not itself a problem. However, what does still seem like a bug is that the ripple disappears and THEN the focus state appears, making it look like it gets 'toggled' after the user taps it.

For example, take a look at this video recording using latest iOS - the paper-icon-button gets tapped only 2 times in this video, but the on state appears to get triggered 4 times because of this combined effect of ripple animation + :focus effects - https://youtu.be/UQq_OJjZxjM (compare with desktop: https://youtu.be/rkUef7Tk5EI)

cdata commented 8 years ago

Hi, I'm going to close this issue as a dupe of https://github.com/PolymerElements/paper-button/issues/24, since it is the same problem. Please refer to the paper-button issue for future discussion and tracking!