search

PolymerElements / paper-icon-button

A Material Design icon button
https://www.webcomponents.org/element/PolymerElements/paper-icon-button
42 stars 44 forks source link

Improve the `tap-highlight-color` #71

Closed abdonrd closed 8 years ago

abdonrd commented 8 years ago

Like the paper-tabs: https://github.com/PolymerElements/paper-tabs/blob/cf354bb2df0b8ec8524bde499560197e27dc7034/paper-tabs.html#L112-L114

Reference: https://github.com/PolymerElements/paper-fab/pull/48/files#r50937454

abdonrd commented 8 years ago

Friendly ping to @bicknellr. I see you in the last commits. :)

bicknellr commented 8 years ago

Oh, could you get this one also? https://github.com/PolymerElements/paper-icon-button/blob/99395773ef073a20dab1c4bb3e6230c59a42f572/paper-icon-button-light.html#L35

Edit: If we figure out rgba(0,0,0,0) is alright on its own, please ignore.

abdonrd commented 8 years ago

Done! https://github.com/PolymerElements/paper-icon-button/pull/88

bicknellr commented 8 years ago

Closing since your new PR has both fixes.