PolymerElements / paper-icon-button

A Material Design icon button
https://www.webcomponents.org/element/PolymerElements/paper-icon-button
42 stars 44 forks source link

Better default ink color #97

Closed JosefJezek closed 7 years ago

JosefJezek commented 8 years ago

Could you set default ink color to currentColor?

color: var(--paper-icon-button-ink-color, --primary-text-color);

TO

color: var(--paper-icon-button-ink-color, currentColor);

https://github.com/PolymerElements/paper-icon-button/blob/master/paper-icon-button.html#L101 https://github.com/PolymerElements/paper-icon-button/blob/master/paper-icon-button-light.html#L49

notwaldorf commented 7 years ago

I don't think this is right, as it would then be inconsistent with all the other paper-elements (which all have the same ink color, as per material design specs). I would recommend just changing --paper-icon-button-ink-color instead