search

PolymerElements / paper-icon-button

A Material Design icon button
https://www.webcomponents.org/element/PolymerElements/paper-icon-button
42 stars 44 forks source link

The docs say that a default icon set is included with this element, but no icon set is. #98

Closed akc42 closed 7 years ago

akc42 commented 7 years ago

The documents says this element includes a "default set" of icons. But it doesn't include any icons, you have to import them separately to make the icon show up.

vvaradarajan commented 7 years ago

The import icon statement is there in paper-icon-button.html.

However this iron-icon.html does not work Changing this to along with bower install of iron-icons works. My guess is to either correct this or remove the import and update the documentation to indicate explicit inclusion of icon file.

notwaldorf commented 7 years ago

Oh, hmm, yeah I think the docs are wrong and should probably be updated. You need to also install iron-icons for this to work.

vvaradarajan commented 7 years ago

The paper-icon-button.html on GitHub can be modified to import the 'iron-icons' instead of 'iron-icon'.

On May 9, 2017 1:43 AM, "Monica Dinculescu" notifications@github.com wrote:

Oh, hmm, yeah I think the docs are wrong and should probably be updated. You need to also install iron-icons for this to work.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/PolymerElements/paper-icon-button/issues/98#issuecomment-300100264, or mute the thread https://github.com/notifications/unsubscribe-auth/AViTvqMDLEyN_0wwYo_I_vh5MZWGe6zIks5r4CcjgaJpZM4KBq1I .

notwaldorf commented 7 years ago

That would not be correct. Paper-icon-button has a hard dependency on iron-icon (which actually renders the icon), but only a dev dependency on iron-icons (so that it's used in the demo). Making that a hard dependency means everyone who wants to use a paper-icon-button would have to download the default set of icons, whether or or not they would use it, which is bad (and expensive)

vvaradarajan commented 7 years ago

Thx for the clarification. I did not know that iron-icon had the rendering portion. I have both iron-icon and iron-icons installed, and when the default paper-icon-button did not display the icon, I changed the paper-icon-button.html to replace iron-icon with iron-icons, and that worked. Now I understand that iron-icons includes the rendering portion AND icons, whereas iron-icon probably has the rendering portion. Thx for reading/responding to my emails.

-Vasan

On Tue, May 9, 2017 at 10:54 AM, Monica Dinculescu <notifications@github.com

wrote:

That would not be correct. Paper-icon-button has a hard dependency on iron-icon (which actually renders the icon), but only a dev dependency on iron-icons (so that it's used in the demo). Making that a hard dependency means everyone who wants to use a paper-icon-button would have to download the default set of icons, whether or or not they would use it, which is bad (and expensive)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/PolymerElements/paper-icon-button/issues/98#issuecomment-300249285, or mute the thread https://github.com/notifications/unsubscribe-auth/AViTvmgc4-nTUSPXgbCQXWYuedbbJbKZks5r4KhxgaJpZM4KBq1I .