search

PolymerElements / paper-input

A Material Design text field
https://www.webcomponents.org/element/PolymerElements/paper-input
130 stars 162 forks source link

1.x: Generate unique IDs for the input in the shadow root #608

Closed notwaldorf closed 6 years ago

notwaldorf commented 6 years ago

The 2.x PR is here: https://github.com/PolymerElements/paper-input/pull/609

Fixes #600: Chrome has recently started throwing some auditing errors in the console if any <input type="password"> has the same id as any other input. This means that in Shady DOM, if you have two paper-inputs on a page, you'd get this error. This fixes that by generating unique IDs for the inputs in the page.

(this is PR https://github.com/PolymerElements/paper-input/pull/602 with like one extra commit on it, thanks @ipuiu for doing all the work!)

googlebot commented 6 years ago

So there's good news and bad news.

:thumbsup: The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

:confused: The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

notwaldorf commented 6 years ago

(Working on the 2.x PR for this same problem; it's a bit more complicated because of timing)