search

PolymerElements / paper-input

A Material Design text field
https://www.webcomponents.org/element/PolymerElements/paper-input
130 stars 162 forks source link

2.x: Generate unique IDs for the input in the shadow root #609

Closed notwaldorf closed 6 years ago

notwaldorf commented 6 years ago

The 1.x PR is here: https://github.com/PolymerElements/paper-input/pull/608

Fixes #600: Chrome has recently started throwing some auditing errors in the console if any <input type="password"> has the same id as any other input. This means that in Shady DOM, if you have two paper-inputs on a page, you'd get this error. This fixes that by generating unique IDs for the inputs in the page.

notwaldorf commented 6 years ago

@valdrinkoshi comment addressed, PTAL?

notwaldorf commented 6 years ago

🍏 📗 💚 🎉