PolymerElements / paper-input

A Material Design text field
https://www.webcomponents.org/element/PolymerElements/paper-input
130 stars 162 forks source link

Fixes Auto-Validation fires directly for required without any user interaction #658

Closed aarondrabeck closed 6 years ago

aarondrabeck commented 6 years ago

This resolves issues 134 and 655 introduced from PR 130.

Allowing '' here (along with undefined) should not create any issues because it is only checking once on startup. The alternative is to revert PR 130 but I am not sure why setting a default was needed.

e111077 commented 6 years ago

Come think of it, why would the default value ever be undefined with the change in PolymerElements/iron-input#130? In polymer 1 it is a native input that is extended so it would be '' and polymer 2 we set it to '' in iron-input

e111077 commented 6 years ago

A test would also be helpful to make sure this regression doesn't happen again

aarondrabeck commented 6 years ago

@notwaldorf Thanks for the merge and test! Is there any way we could get a release with this in it?

e111077 commented 6 years ago

We are currently reviewing our internal test suite results. You should expect a release later today or a rollback depending on the result

aarondrabeck commented 6 years ago

Thanks!