PolymerElements / paper-input

A Material Design text field
https://www.webcomponents.org/element/PolymerElements/paper-input
130 stars 162 forks source link

make sure event.target is the real addons target #691

Open christophe-g opened 5 years ago

christophe-g commented 5 years ago

We want the real addons target to be added as addons.

Due to shadowDom event retargeting, event.target is is not the addon anymore in some advanced templating scenario. As a result, updateAddons call a not-existing update method, creating an error.

This PR makes sure we add the initial event target.

This PR is against the 2.x branch (which I use), but the observed error is expected to happen under 3.x as well.

e111077 commented 5 years ago

Unfortunately we are still doing a large internal migration that may result in an external major release of paper-input. We are in a code freeze for the element and iron-input in the meanwhile.