search

PolymerElements / paper-input

A Material Design text field
https://www.webcomponents.org/element/PolymerElements/paper-input
130 stars 162 forks source link

Update autofocus property to be non-nullable #704

Closed rrdelaney closed 4 years ago

rrdelaney commented 4 years ago

In TypeScript 3.8 a new property autofocus was introduced on HTMLElement. When a component like gold-phone-input extends both this behavior and HTMLElement the autofocus properties now conflict. This change marks autofocus as non-nullable to align with TypeScript's HTMLElement.

Here's a playground link demoing the issue: http://www.typescriptlang.org/play/#code/JYOwLgpgTgZghgYwgAgJIgA4FcwCEIAWcAbsAPZTIDeAUMvcnDmTGQlgM4BcyARmWQA2EOCGQAfZCCyDBE5FhAATCDFAQlAbhoBfGjVCRYiFAAUCZEBHTYwyCAA9Iyjmkw58RUhQA0yABIAKgCyADIAosIAthDg1HQMujRAA

To see past behavior set the version to 3.7.5, and the current by setting the version to 3.8.3.

e111077 commented 4 years ago

awaiting internal testing

rrdelaney commented 4 years ago

@e111077 is there anything else needed to land these changes?

e111077 commented 4 years ago

Hi, sorry was OOO the first half of this week. Currently catching up on status of everything and will update you by EoD

e111077 commented 4 years ago

all good in the neighborhood

e111077 commented 4 years ago

released