Remove unnecessary import

PolymerElements / paper-progress

A Material Design progress

32 stars 43 forks source link

Remove unnecessary import #22

Closed blasten closed 8 years ago

blasten commented 8 years ago

paper-progress does not use this import and it's throwing a warning in the console: /deep/ combinator is deprecated.

Also, iron-shadow-flex-layout.html is automatically imported from paper-styles. That will continue to throw the warning...

addyosmani commented 8 years ago

LGTM

samccone commented 8 years ago

LGTM :dancer:

notwaldorf commented 8 years ago

FYI, you will still get the deprecation warning from the paper-styles import. paper-styles.html includes classes/iron-flex-layout.html which is knee deep in /deep/ and ::shadow

addyosmani commented 8 years ago

@notwaldorf OT: Given the deprecation plans around /deep/, do we have a timeline for no longer keeping them around and just switching to the custom props import?

notwaldorf commented 8 years ago

@addyosmani Working on this right now! Unfortunately, it's kinda hairy and I don't have a good plan not to break people who've been relying on /deep/ yet.

frankiefu commented 8 years ago

LGTM :+1: