search

PolymerElements / paper-progress

A Material Design progress
32 stars 43 forks source link

Set aria-valuenow only if progress bar is determinate #43

Closed gsathya closed 1 year ago

gsathya commented 8 years ago

According to the W3 Aria[0] spec -- "If the current value is not known (for example, an indeterminate progress bar), the author SHOULD NOT set the aria-valuenow attribute."

I couldn't find instructions to run the demo locally to double check, but the change seems straightforward enough.

[0] -- https://www.w3.org/TR/wai-aria/states_and_properties#aria-valuenow

keanulee commented 8 years ago

Also, tests would be appreciated (though if you don't want to make them I can do it in a separate PR later).

gsathya commented 8 years ago

Also, tests would be appreciated (though if you don't want to make them I can do it in a separate PR later).

Will do in a separate PR. I need to figure out how to run them first, I'll swing by your desk tomorrow or wednesday.