search

PolymerElements / paper-progress

A Material Design progress
32 stars 43 forks source link

Doc missing: to enable the animation must use the class="transiting" #48

Open yangchenyun opened 7 years ago

yangchenyun commented 7 years ago

Both the demo and the doc missed this class, the animation won't happen and the variables won't be effective unless you have .transiting set.

keanulee commented 7 years ago

@yangchenyun It's in the docs https://github.com/PolymerElements/paper-progress/blob/master/paper-progress.html#L54 and also in the README.

yangchenyun commented 7 years ago

Sorry, missed it when reading the doc. 👍

As other Polymer components, the behavior/API is configured through properties; this seems a out-of-box case; maybe more consistent if this is defined as a property and reflecting to attribute.

keanulee commented 7 years ago

@blasten Possible API change for the next version (ref #11)?

blasten commented 7 years ago

+1. Added it to the milestone.