PolymerElements / paper-progress

A Material Design progress
32 stars 43 forks source link

Add progress container mixin #49

Closed bobbijvoet closed 7 years ago

bobbijvoet commented 7 years ago

I needed to add some extra styles to the progress container element. Then I discovered that unlike a lot of other paper elements, the paper-progress did not have a mixin for applying styles to the container element. This PR adds that mixin.

googlebot commented 7 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

bobbijvoet commented 7 years ago

I accidentally used a different email address for the commit. Added this email address to my account, so should be ok now.

googlebot commented 7 years ago

CLAs look good, thanks!

keanulee commented 7 years ago

@bobbijvoet Do you have an example of what you need to style in the progress container element? Perhaps there's another way from the outside?

bobbijvoet commented 7 years ago

I need an inset shadow on the progress container to show an inner border. I tried several ways but didn't succeed to reach the inner div. I looked at other paper elements and noticed that most of them actually have mixins for their containers, to follow that rule it should be added to progress as well.

keanulee commented 7 years ago

LGTM. Thanks @bobbijvoet

bobbijvoet commented 7 years ago

Great! Many thanks @keanulee