PolymerElements / paper-progress

A Material Design progress
32 stars 43 forks source link

Use border instead of background for styling #64

Closed keanulee closed 6 years ago

keanulee commented 7 years ago

Fixes #57

Note that this effectively renders the --paper-progress-container mixin useless - the mixin is still applied, but the background color of the slider is moved to another element (from #progressContainer to #progressContainer::before) so styling things like border radius (see #13) and inset shadow (#49) is no longer possible.

keanulee commented 6 years ago

Due to the fact that this would be a breaking change, we will not be merging this. Feel free to examine the code and create your own slider if this functionality is desired.

danbeam commented 6 years ago

whomp whomp might fork this element in Chrome's code, then

danbeam commented 6 years ago

/cc @freshp86

danbeam commented 6 years ago

thank you for the PR, but this didn't really fix much for me (at least in Chrome settings). probably something else in the way that doesn't use border (and is being rounded down to 0 at 25% zoom).