search

PolymerElements / paper-ripple

Adds a Material Design ripple effect to UI elements
https://webcomponents.org/element/PolymerElements/paper-ripple
56 stars 27 forks source link

noink property missing reflectToAttribute #50

Closed CelineBen closed 8 years ago

CelineBen commented 8 years ago

Would it make sense to add reflectToAttribute: true to the noink property ? It looks like this is never applied:

:host([noink]) {
    pointer-events: none;
}

Edit: I mean when the paper-ripple is added dynamically through another component such as paper-button.

notwaldorf commented 8 years ago

I've just landed a PR that makes paper-ripple have pointer-events none all the time, so that style doesn't really make a difference anymore. Also, there have been recent changes in paper-ripple and paper-behaviors that make noink actually work correctly everywhere, so that style can just be removed On Tue, Oct 13, 2015 at 3:45 PM Céline Bensoussan notifications@github.com wrote:

Would it make sense to add reflectToAttribute: true to the noink property ? It looks like this is never applied:

:host([noink]) { pointer-events: none; }

— Reply to this email directly or view it on GitHub https://github.com/PolymerElements/paper-ripple/issues/50.

CelineBen commented 8 years ago

Thank you.