search

PolymerElements / paper-ripple

Adds a Material Design ripple effect to UI elements
https://webcomponents.org/element/PolymerElements/paper-ripple
57 stars 27 forks source link

Initial import of new ripple code. #63

Closed rfru closed 8 years ago

rfru commented 8 years ago

This implements the updated ripple spec, with support for unbounded ripples.

rfru commented 8 years ago

All changes have been made. I also made an attempt at porting some of the current API functionality, namely the programmatic triggering of the ripple.

Let me know if I should start writing tests.

cdata commented 8 years ago

Would it be possible to write some tests for PaperClock and PaperTween?

rfru commented 8 years ago

Addressed comments and added tests. Please take a look.

cdata commented 8 years ago

Unfortunately, after some discussion with the team we have come to a consensus that the cost of a specialized paper-ripple-foreground and paper-ripple-background element is too high for an element with as much frequency as paper-ripple. We need to adapt the design so that these are no longer represented as stand-alone Custom Elements.

This doesn't necessarily need to result in a traumatic change in the overall design. If we could represent the implementation for these elements as plain-old-JS classes - without using data-binding or other Polymer sugar, and the fewest number of extra DOM nodes possible - that might be sufficient.

rfru commented 8 years ago

Updated with converted foreground and background elements. Please take a look.

rfru commented 8 years ago

Friendly ping here :)