Closed Sleeckx closed 8 years ago
/cc @valdrinkoshi @dschuyler
Valdrin: I think this has been introduced by the other PR we merged. Should we revert it in the meantime?
I believe the bug is in iron-a11y-keys-behavior
which should accept null as valid value and handle it (it is currently being done in this PR https://github.com/PolymerElements/iron-a11y-keys-behavior/pull/47).
@valdrinkoshi I'm afraid the above issue is still present in the current build..
That's correct, this gets fixed by https://github.com/PolymerElements/iron-a11y-keys-behavior/pull/48
Description
Moving an element that contains paper-ripple, or paper-ripple itself, from one location in the DOM to another will cause an error. Maybe the keyEventTarget should be set to
this
instead ofnull
in thedetached
function, since this is also the default value for this property in the iron-a11y-keys-behavior?Edit: Just noticed this is already up for discussion PolymerElements/paper-ripple/pull/79
Expected outcome
Paper-ripple elements should be able to move around in the DOM freely.
Actual outcome
iron-a11y-keys-behavior throws an error during attached:
TypeError: Cannot read property 'addEventListener' of null at paper-ripple.<anonymous> (https://polygit.org/components/iron-a11y-keys-behavior/iron-a11y-keys-behavior.html:404:30)
Live Demo
https://jsbin.com/hitayuvode/edit?html,console,output
Steps to reproduce
paper-ripple
element in the page.Browsers Affected