search

PolymerElements / paper-slider

A Material Design slider
47 stars 84 forks source link

Support LTR sliders in RTL pages #199

Closed keanulee closed 7 years ago

keanulee commented 7 years ago

Ref #190

This will setting a different direction with HTML attributes, like:

<html dir="rtl">
...
<paper-slider dir="ltr">

But not through CSS (which would require an expensive getComputedStyle() for bootup).

takumif commented 7 years ago

I'd like to know which Chrome milestone this fix will be included in. Is there an easy way for me to figure that out? Or, is it possible to have this merged into Chrome M61?

keanulee commented 7 years ago

@dschuyler might be able to answer that question ^

dschuyler commented 7 years ago

I did a quick look at the chromium code using code search and it doesn't look like this is present:

https://cs.chromium.org/chromium/src/third_party/polymer/v1_0/components-chromium/paper-slider/paper-slider.html?type=cs&q=%22:host-context(%5Bdir%3D%22rtl%22%5D)+%23sliderContainer%22&sq=package:chromium&l=92

takumif commented 7 years ago

Right, Chromium currently uses paper-slider v1.0.15 and this patch isn't included until v2.0.2. I was wondering if I can assume that Chrome M61 won't ship with v2.0.2 or later, since in that case I'll need to land a workaround similar to this in Chromium.

takumif commented 7 years ago

I've updated the paper-slider used in Chromium to v2.0.2: https://chromium-review.googlesource.com/c/565067/