PolymerElements / paper-slider

A Material Design slider
47 stars 84 forks source link

Fixed bug in RTL where the pin content was mirrored and unreadable #229

Open yosilevy opened 5 years ago

yosilevy commented 5 years ago

Before fix (look at the pin):

slider-pin-before

After fix (ignore the number mismatch below - it's because of the screen cap)

slider-pin-after
googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
yosilevy commented 5 years ago

I signed it!

googlebot commented 5 years ago

CLAs look good, thanks!

e111077 commented 5 years ago

pending internal testing

e111077 commented 5 years ago

This unfortunately breaks YouTube. Looking into this a bit more to see if I can give any actionable advice

e111077 commented 5 years ago

Your code seems fine; it looks like it's a bug with our internal CSS builder. Unfortunately this means that I cannot merge this until we resolve this issue.