📐 Expose height css var

PolymerElements / paper-toolbar

A Material Design toolbar/appbar

https://www.webcomponents.org/element/PolymerElements/paper-toolbar

40 stars 41 forks source link

📐 Expose height css var #40

Closed samccone closed 9 years ago

samccone commented 9 years ago

Fixes #39

chuckh commented 9 years ago

LGTM

blasten commented 9 years ago

@samccone LGTM too. I only have two comments:

Fix the tests: has expected medium-tall height and has expected tall height
Add the new variables to the readme.md as well.

blasten commented 9 years ago

friendly ping @samccone

samccone commented 9 years ago

oh yes will do today!

samccone commented 9 years ago

:pineapple: Emoji fun fact of the day:

The pineapple made its way to England in the 17th century and by the 18th century, being seen with one was an instant indicator of wealth -- a single pineapple could cost the equivalent of $8,000 today. In fact, the fruit was so desirable and rare that consumers often rented a pineapple for the night to show off to fellow party-goers.

samccone commented 9 years ago

@blasten let me know what you think :thought_balloon:

clintwood commented 9 years ago

@samccone, @blasten, this doesn't make sense without also applying --paper-toolbar-height to .toolbar-tools, here and here as mentioned in #44!

samccone commented 9 years ago

great good call @clintwood I will add this to the PR

clintwood commented 9 years ago

Awesome!

blasten commented 9 years ago

+1 --paper-toolbar-sm-height

samccone commented 9 years ago

@blasten can you explain what you mean?

samccone commented 9 years ago

also @blasten @clintwood this should be all set now

samccone commented 9 years ago

@blasten :)

blasten commented 9 years ago

LGTM. merged now, thanks!

samccone commented 9 years ago

:bow:

clintwood commented 9 years ago

Great stuff!