PolymerElements / paper-toolbar

A Material Design toolbar/appbar
https://www.webcomponents.org/element/PolymerElements/paper-toolbar
40 stars 41 forks source link

colors :) #77

Closed bkr32 closed 8 years ago

bkr32 commented 8 years ago

dear polymer, the last commit has changed how primary-text-color andtext-primary-color work, effectively making text-primary-color deprecated except all other elements still use it for text and icons will there be a update really soon to all elements to make the switch? is there any way to have other elements that used primary-text-color for dark colors/fonts use text-primary-color? here is my current theme <--dark-primary-color: #1976D2; --default-primary-color: #2196F3; --light-primary-color: #BBDEFB; --primary-text-color: #ffffff; /*text/icons*/ --accent-color: #FF5252; --primary-background-color: #BBDEFB; --text-primary-color: #212121; --secondary-text-color: #727272; --disabled-text-color: #bdbdbd; --divider-color: #B6B6B6;> in the attached image, the black circled content uses primary-text-color whereas the green uses text-primary-color untitled

bicknellr commented 8 years ago

I think we're currently in the process of making this switch. @notwaldorf, is that correct?

notwaldorf commented 8 years ago

We're working on it. If you're interested in helping, please send us PRs for any of the elements that you encounter that are still being! 🍰

(We've been slow on making new releases of elements, so double check that the right property isn't used on the master trunk, too)

bkr32 commented 8 years ago

thanks for the heads up, hope making the transition doesn't take too long, i will let you know if any other elements that have issues

miztroh-zz commented 8 years ago

@notwaldorf Is this why (since my bower update yesterday) all my paper-toolbars have #212121-colored text instead of white?

http://jsbin.com/kulukomoha/edit?html,output

bicknellr commented 8 years ago

Yup: here from here from here.

notwaldorf commented 8 years ago

--primary-text-color has always been #212121 (see https://github.com/PolymerElements/paper-styles/blob/42255df7e783880c8b4e87a9dc8ce601c8f913c3/default-theme.html#L29) so the paper-styles change shouldn't have affected this.

the paper-styles change was cosmetical and 100% backwards compatible, so it shouldn't have broken any existing values.

bicknellr commented 8 years ago

@notwaldorf This commit changed --text-primary-color to --primary-text-color the first of which is white, the second is #212121. Should we revert?

chuckh commented 8 years ago

The change to using --primary-text-color for paper-toolbar caused Polymer Starter Kit to go from:

Before:

image


After:

image

paper-toolbar color should default to white not #212121.

rajat1saxena commented 8 years ago

Broke my toolbar as well :( . I was using orange background for the toolbar, it has gone too. My toolbar is now #3f51b5.