search

PolymerElements / platinum-sw

Service Worker Polymer element
67 stars 16 forks source link

Fixes #43 #44

Closed ebidel closed 9 years ago

ebidel commented 9 years ago

R: @jeffposnick @wibblymat

addyosmani commented 9 years ago

lgtm (however I can't recall why childNodes was used instead of children). Deferring to Jeff and Mat

wibblymat commented 9 years ago

I believe that I wrote that line when translating from 0.5 to 0.8. No special reason for one over the other - I didn't realise that there was an alternative, or really what childNodes actually did.

jeffposnick commented 9 years ago

I think I wrote that bit, but I basically have the same explanation as @wibblymat—it may have been because I saw Polymer.dom(parent).childNodes listed in the docs and assumed that was the right thing to use.

:+1: if this fixes the issue you were seeing.

I'll cut a new release after addressing the docs issues in https://github.com/PolymerElements/platinum-sw/issues/45