Default to [] in precachePromise

PolymerElements / platinum-sw

Service Worker Polymer element

67 stars 16 forks source link

Default to [] in precachePromise #90

Closed jeffposnick closed 8 years ago

jeffposnick commented 8 years ago

R: @wibblymat @addyosmani @gauntface

Without this change, [undefined] is passed to toolbox.precache() when there is no precache config. This didn't lead to anything too drastic in earlier versions of Chrome, but starting in Chrome 50, failed fetches in the underlying cache.addAll() call will caught the promise to reject.

wibblymat commented 8 years ago

Build fails in FF, but it doesn't seem related to this so LGTM.

gauntface commented 8 years ago

:+1: