search

PolymerElements / prism-element

Prism-based syntax highlighting
17 stars 19 forks source link

Add property to extend languages in shadow-mode. #28

Closed wesalvaro closed 7 years ago

wesalvaro commented 7 years ago

Extending the list of languages supported cannot be done currently when shadow-mode is enabled. This adds a property to accept more language definitions/overrides when operating in shadow-mode.

wesalvaro commented 7 years ago

R: @ebidel

wesalvaro commented 7 years ago

+R: @notwaldorf Seems you might like to take a look given this has to do with shadow-mode functionality as in the recent release.

ebidel commented 7 years ago

I defer to @notwaldorf on this. It's her element.

notwaldorf commented 7 years ago

Actually, @FredKSchott is the new owner of this element, not me. I think this looks fine, but it's his call.

wesalvaro commented 7 years ago

lol, thanks all. @FredKSchott What do you think?

FredKSchott commented 7 years ago

LGTM! I'm surprised this hasn't been supported yet, but I guess we've only ever used it for frontend languages (bundled by default with prism).

Thanks for the contribution and thorough documentation around the new option.