search

PolymerElements / test-fixture

21 stars 14 forks source link

nested repeat test #6

Closed atotic closed 8 years ago

atotic commented 9 years ago

Added a test that demonstrates a bug with dom-repeat fixtures on Safari.

atotic commented 9 years ago

@cdata Found the cause: Safari.importNode nested template contents are not cloned. Bug was reported, and patched, but patch obviously not shipping yet: https://bugs.webkit.org/show_bug.cgi?id=137619 There is another call to importNode in polymer/src/mini/template.html that might be affected by this. Writing safariImportNode() workaround is left as an exercise to the reader.

cdata commented 9 years ago

Nice find! Hopefully we can work around this.

On Tue, May 19, 2015 at 10:53 PM, Aleksandar Totic <notifications@github.com

wrote:

@cdata https://github.com/cdata Found the cause: Safari.importNode nested template contents are not cloned. Bug was reported, and patched, but patch obviously not shipping yet: https://bugs.webkit.org/show_bug.cgi?id=137619 There is another call to importNode in polymer/src/mini/template.html that might be affected by this. Writing safariImportNode() workaround is left as an exercise to the reader.

— Reply to this email directly or view it on GitHub https://github.com/PolymerElements/test-fixture/pull/6#issuecomment-103770311 .

atotic commented 9 years ago

Bug is already known: https://github.com/Polymer/polymer/issues/1443 If you read through, kevin suggests using dom-if, since they already handle this in their stamping code. But, test-fixture is not a polymer element, so.....

cdata commented 8 years ago

@atotic after talking with the core guys, I don't think this test will ever pass (even when the "bug" in Polymer is fixed). I'm gonna close the PR for now, let's talk about it offline!