Make commands in tool/local-presubmit to be steps in cloudbuild.yaml

PolymerLabs / arcs

Arcs

BSD 3-Clause "New" or "Revised" License

58 stars 35 forks source link

Make commands in tool/local-presubmit to be steps in cloudbuild.yaml #4550

Open bgogul opened 4 years ago

bgogul commented 4 years ago

PR https://github.com/PolymerLabs/arcs/pull/4542 adds a configuration where the tests are run through a local/presubmit script. It is possible to make each command in tools/local-presubmit as steps in cloudbuild.yaml. The advantage is that these can be run in parallel if resources are available.

The downside is that we will need to keep cloudbuild.yaml and tools/local-presubmit in sync.

bgogul commented 4 years ago

Documenting the results of my investigation. By splitting the steps, we might be able to save 2-3 minutes in gcb build. However, this would require non-trivial amount of work. It looks like the everything except sigh lintneeds to be run in sequence as the earlier steps in presubmit produce artifacts used by subsequent steps.