Closed pwasem closed 2 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!
) and we'll verify. Thanks.
CLAs look good, thanks!
Any thoughts on this one yet?
Scripts should each be wrapped in immediately invoked function expressions (IIFEs) on concatenation as mentioned in Effective Javascript by David Herman (chapter 1). This would avoid several problems, e.g. considering scopes and usage of "use strict";
So instead of:
The concatenated file should look like:
Implementation should be easy: