search

PolymerLabs / polymon

Seek out Polymer team members and capture them as Polymon! https://polymon.polymer-project.org
10 stars 2 forks source link

Adds a logout button to the start screen; use material SVG icons for the mute button. #93

Closed bicknellr closed 7 years ago

bicknellr commented 7 years ago

This PR depends on #85. The font size of the buttons on the start screen (only) have also been increased to 20px to match the photoshop mocks. Also, there isn't an official material 'log out' icon AFAIK, so I edited the 'exit to app' one to something similar to other log out icons.

#85 #85 + this PR
screen shot 2017-05-03 at 11 07 51 screen shot 2017-05-03 at 17 36 54
screen shot 2017-05-03 at 11 15 26 screen shot 2017-05-03 at 11 15 30 screen shot 2017-05-03 at 11 15 00 screen shot 2017-05-03 at 11 15 08
screen shot 2017-05-03 at 11 11 09 screen shot 2017-05-03 at 11 10 54
e111077 commented 7 years ago

I really like the sound button. It was confusing whether the old icon meant that it is muted or whether it will mute

e111077 commented 7 years ago

also, shouldn't the sign out button be pointing out of the door instead of in?

image

It kinda looks like the icon to open in my browser

bicknellr commented 7 years ago

also, shouldn't the sign out button be pointing out of the door instead of in?

Yeah, I totally agree. Where did you get that icon?

e111077 commented 7 years ago

@bicknellr I googled it so you probably shouldn't use that one

e111077 commented 7 years ago

don't we use font-awesome somewhere? ~Can we just take the svg?~ It's some fancy .woff2 file.

http://fontawesome.io/icon/sign-out/

bicknellr commented 7 years ago

I took the old one and hacked it up to look more like the example you posted. (screenshot updated)

e111077 commented 7 years ago

suh-weet!

e111077 commented 7 years ago

That's an LGTM pending #85

cdata commented 7 years ago

LGTM 👍 Resolve conflicts then merge it!