search

PolymerLabs / polymon

Seek out Polymer team members and capture them as Polymon! https://polymon.polymer-project.org
10 stars 2 forks source link

Updates the qr-code scanner styles; adds a switch camera button. #97

Closed bicknellr closed 7 years ago

bicknellr commented 7 years ago
before after
back-facing
screenshot_2017-05-05-14-00-12 screenshot_2017-05-05-13-55-37
front-facing
screenshot_2017-05-05-13-55-27
screenshot_2017-05-05-14-00-25 screenshot_2017-05-05-13-56-01
screenshot_2017-05-05-14-03-37 screenshot_2017-05-05-14-03-54
e111077 commented 7 years ago

Why would you want to switch the camera?

bicknellr commented 7 years ago

I was running into some situations where it would either launch the front camera or the camera labels were blank and would cause this snippet to flip back and forth between cameras. Otherwise, yeah, I don't think there's any real reason to switch once they've selected the right one; E[clicks / user] = 0.5, maybe even less.

e111077 commented 7 years ago

upon my approval, I think @cdata needs to still take a look as I'm not too familiar with the camera api

bicknellr commented 7 years ago

Screenshots added.

bicknellr commented 7 years ago

Oh, do we still want the Polymer logo spinner? Maybe I should just change the color to teal?

bicknellr commented 7 years ago

Also, here's another option for styling the 'switch camera' button:

front back
screenshot_2017-05-05-15-00-13 screenshot_2017-05-05-15-00-33
unknown
screen shot 2017-05-05 at 15 10 34
e111077 commented 7 years ago

I like the first set of switch camera ones. Im on the fence on the color though. Not sure what it should be

bicknellr commented 7 years ago

Ok, the current set of commits only includes the first set of screenshots.

bicknellr commented 7 years ago

I changed it to the color of the larger button: screenshot_2017-05-05-18-23-28

cdata commented 7 years ago

Left some comments. Take 'em or leave 'em. Looking pretty cool.

e111077 commented 7 years ago

🎉