search

PolymerLabs / project-health

Apache License 2.0
9 stars 3 forks source link

Fixes year string. #532

Closed paullewis closed 6 years ago

paullewis commented 6 years ago

Currently the output says '1 years ago'. This should change that so it's '1 year ago', and 'n years ago' for all values of n that aren't 1 👍

R @samuelli

paullewis commented 6 years ago

Fair! I broadened its horizons some.

paullewis commented 6 years ago

@samuelli The build on Travis seems to fail because of OpenSSL, not something in my code. What's the best thing to do here?

samuelli commented 6 years ago

@samuelli The build on Travis seems to fail because of OpenSSL, not something in my code. What's the best thing to do here?

Fix it! If you can review https://github.com/PolymerLabs/project-health/pull/534 that should fix this PR.

samuelli commented 6 years ago

@paullewis: oh I can't rebase it. Can you rebase this change? I guess I could disable the checks requirement and force merge it since it's completely fine.