search

PolymerLabs / project-health

Apache License 2.0
9 stars 3 forks source link

Automerge doesn't appear for incoming pull requests #535

Open dstoc opened 6 years ago

dstoc commented 6 years ago

Expected Behavior

After I approve an incoming pull request I should be able to set the auto-merge option from project-health.

samuelli commented 6 years ago

Are there any restrictions? Sample restrictions:

dstoc commented 6 years ago
  • PR author doesn't have merge abilities

Not sure about that one. That seems a case where the reviewer would be required to merge it.

samuelli commented 6 years ago

Right, but if they did have merge abilities, should you also see the auto-merge option? If you did, then both of you could have the auto merge option available for the same PR.

dstoc commented 6 years ago

Right, but if they did have merge abilities, should you also see the auto-merge option? If you did, then both of you could have the auto merge option available for the same PR.

Yes. I often merge other project member's PRs -- when we're operating in different timezones it results in changes landing much faster.

dstoc commented 6 years ago

If you did, then both of you could have the auto merge option available for the same PR.

If both author + reviewer use automerge, that seems OK -- doesn't really matter too much which one goes ahead.

samuelli commented 6 years ago

If both author + reviewer use automerge, that seems OK -- doesn't really matter too much which one goes ahead.

You could have contention over what method to use though.

@gauntface: how possible do you think this is? I'm not sure how the auto merge stuff is stored rn.

gauntface commented 6 years ago

Steps for adding this would be:

1.) Figure out when to show the UI for automerge to the reviewer. 2.) Store the automerge option in the backend (this is done against the PR itself, so would sync between reviewer and PR author). 3.) The automerge should just work from this.