search

PolymeshAssociation / Polymesh

Node for Polymesh Blockchain
https://polymesh.network/
GNU General Public License v3.0
165 stars 47 forks source link

MESH-1907 Use the same runtime api as Substrate. #1370

Closed Neopallium closed 1 year ago

Neopallium commented 1 year ago

Revert part of PR #1343 to match the public runtime-api from Substrate: https://github.com/PolymeshAssociation/substrate/blob/polymesh-monthly-2022-05-2/frame/transaction-payment/rpc/runtime-api/src/lib.rs

codecov[bot] commented 1 year ago

Codecov Report

Merging #1370 (6e24990) into develop (6e24990) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 6e24990 differs from pull request most recent head c59ff51. Consider uploading reports for the commit c59ff51 to get more accurate results

@@           Coverage Diff            @@
##           develop    #1370   +/-   ##
========================================
  Coverage    43.35%   43.35%           
========================================
  Files          140      140           
  Lines        30112    30112           
========================================
  Hits         13056    13056           
  Misses       17056    17056
Neopallium commented 1 year ago

Also apply the same change as in: https://github.com/paritytech/substrate/pull/6792/files

Neopallium commented 1 year ago

FYI, tested using a 4.0 dev chain and Polymesh from this PR. Note the latest Polkadot uses state_call to call the query_info API. Our current webapps still use the old RPC endpoint for query_info. Both work correctly using this PR.