PolymeshAssociation / Polymesh

Node for Polymesh Blockchain
https://polymesh.network/
GNU General Public License v3.0
165 stars 47 forks source link

Move settlement definitions #1439

Closed HenriqueNogara closed 1 year ago

HenriqueNogara commented 1 year ago

This PR moves the types defined in pallet_settlement to primitives, the schedule_name_prefix constants to primitives and the Eventand WeightInfo trait to common.

changelog

modified API

codecov[bot] commented 1 year ago

Codecov Report

Merging #1439 (b2df2fb) into MESH-1953/execute-scheduled-instruction-weight (6af375d) will decrease coverage by 0.01%. The diff coverage is 43.58%.

@@                                Coverage Diff                                 @@
##           MESH-1953/execute-scheduled-instruction-weight    #1439      +/-   ##
==================================================================================
- Coverage                                           54.32%   54.31%   -0.01%     
==================================================================================
  Files                                                 147      149       +2     
  Lines                                               32658    32682      +24     
==================================================================================
+ Hits                                                17740    17751      +11     
- Misses                                              14918    14931      +13     
Impacted Files Coverage Δ
pallets/common/src/lib.rs 68.75% <ø> (ø)
pallets/common/src/traits/mod.rs 0.00% <ø> (ø)
pallets/common/src/traits/settlement.rs 0.00% <0.00%> (ø)
pallets/multisig/src/lib.rs 81.54% <ø> (-0.03%) :arrow_down:
pallets/pips/src/lib.rs 86.16% <ø> (-0.06%) :arrow_down:
pallets/runtime/common/src/runtime.rs 1.69% <ø> (ø)
pallets/sto/src/lib.rs 49.57% <ø> (ø)
primitives/src/lib.rs 79.12% <ø> (ø)
primitives/src/settlement.rs 68.71% <68.71%> (ø)
pallets/settlement/src/lib.rs 80.87% <77.77%> (+4.77%) :arrow_up:

... and 3 files with indirect coverage changes