Closed HenriqueNogara closed 1 year ago
Merging #1483 (22a49de) into develop (efa610d) will increase coverage by
0.18%
. The diff coverage is75.31%
.
@@ Coverage Diff @@
## develop #1483 +/- ##
===========================================
+ Coverage 54.41% 54.59% +0.18%
===========================================
Files 151 151
Lines 32949 33031 +82
===========================================
+ Hits 17928 18033 +105
+ Misses 15021 14998 -23
Impacted Files | Coverage Δ | |
---|---|---|
pallets/common/src/traits/settlement.rs | 0.00% <0.00%> (ø) |
|
primitives/src/weight_meter.rs | 68.33% <0.00%> (+1.12%) |
:arrow_up: |
pallets/weights/src/pallet_settlement.rs | 52.99% <57.37%> (+0.36%) |
:arrow_up: |
pallets/settlement/src/lib.rs | 79.18% <78.32%> (+1.04%) |
:arrow_up: |
primitives/src/settlement.rs | 80.97% <90.58%> (+7.13%) |
:arrow_up: |
pallets/sto/src/lib.rs | 50.10% <100.00%> (+0.21%) |
:arrow_up: |
As discussed:
change_receipt_validaty
This PR changes how offchain affirmations are handled. Explicit affirmation from both the sender and receiver are no longer required.
changelog
modified API
Leg
has been updated and is now anenum
;DuplicateReceiptUid
,ReceiptInstructionIdMissmatch
,MultipleReceiptsForOneLeg
andUnexpectedLegStatus
error variants have been added for thesettlement_pallet
;FailedToLockTokens
,PortfolioMismatch
, andOffChainAssetMustBeAffirmedWithReceipts
error variants have been removed from thesettlement_pallet
;polymesh_schema.json
has been updated with the new leg type;modified logic
data migration