search

Polytechnique-org / xorgauth

Polytechnique.org Authentication / Authorization provider
GNU Affero General Public License v3.0
1 stars 5 forks source link

accept case insensitive logins #114

Closed symphorien closed 6 years ago

symphorien commented 6 years ago

Fixes #65 The diff is unreadable, but it is only:

def get_for_login():
   def lookup():
        #former content of get_for_login()
   return lookup(username) or lookup(username.lower())
fishilico commented 6 years ago

Thanks! You may add a comment like "Allow login to be insensitive to the letter case" for lookup(username) or lookup(username.lower()). Moreover there should be some new tests to ensure this works correctly. The code in itself looks good to me and I will write the tests if you do not have time to do this.

symphorien commented 6 years ago

I have copy pasted some tests