search

Polytechnique-org / xorgauth

Polytechnique.org Authentication / Authorization provider
GNU Affero General Public License v3.0
1 stars 5 forks source link

Use case-insensitive login? #65

Closed fishilico closed 6 years ago

fishilico commented 6 years ago

Some people may want to use uppercase in their usernames/emails. In order for this to work transparently, the comparison in the database needs to be case-insensitive, when looking for a user. This can be easily implemented thanks to Django's __iexact query modifier (https://docs.djangoproject.com/en/dev/ref/models/querysets/#iexact).

What do you think? Should I submit a PR implementing this?

elinorbgr commented 6 years ago

I don't see any downside of doing it, though I don't see it as top priority. Are there many people trying to upper-case their emails?

GuillaumeDIDIER commented 6 years ago

By the way since we need to go and touch the code for that in #88, do you think it is worth my time killing two birds with the same rock by fixing this ?

elinorbgr commented 6 years ago

Absolutely ! 👍