search

Polytonic / Glitter

Dead Simple OpenGL
http://polytonic.github.io/Glitter/
2.46k stars 416 forks source link

Build failure #40

Closed yurivict closed 6 years ago

yurivict commented 6 years ago 
tmp/Glitter/Glitter/Vendor/assimp/code/glTFExporter.cpp:585:35: error: ordered comparison between pointer and zero ('aiVector3D *' (aka 'aiVector3t<float> *') and 'int')
                if(comp_allow && (aim->mNormals > 0)) idx_srcdata_normal = b->byteLength;// Store index of normals array.
                                  ~~~~~~~~~~~~~ ^ ~

You shouldn't bundle packages, because now you own their build problems. assimp provides .cmake file and is actually installed on my system.

clang-40 on FreeBSD.

Polytonic commented 6 years ago

Hi there! Thanks for the feedback.

Are you still experiencing this build failure?

yurivict commented 6 years ago

I had to update bundled dependencies to the latest version for it to go away.

Polytonic commented 6 years ago

Sounds like you've fixed your problem, so I'll go ahead and close this issue for now. Feel free to reopen or open a new issue if you continue to have problems.

For what it's worth, I periodically go through and update the bundled dependencies. It sounds like I need to bump the versions again. I appreciate the data point!

yurivict commented 6 years ago

You need to update revisions of modules. Otherwise it doesn't build out of the box.