Closed EatChangmyeong closed 2 years ago
Thank you so much for getting Korean translations started! If this is specifically the korean version of noto sans, let's make sure the filename indicates that too so it won't conflict with a future use of another language/locale-specific version of noto, though.
And of course: happy new year =)
Hm, it looks like this might need a rebase, too, since the master branch got updated a few times. Would you be up for that?
Actually I'm not used to how Git and GitHub works, but I'll try -- I'll let you know when I succeed.
I just pulled your changes, do I need to run npm start
again?
generally yes, that'll generate updated .html files
All done, is there something else I should do?
Just one small thing and then this can be merged in.
in it goes!
I've translated the preface chapter into Korean (ko-KR); I'd also like to contribute to a few more chapters in the future.
A number of translation concerns:
font-size
is 17.2px for now but I'm not confident with this value.locale-strings.js
is fully translated, with the exception ofdonationCTA
,bitcoinHeading
andbitcoinCTA
.PS: Thank you for the great work! I had to work with Beziér maths time to time and your primer always helped me a lot.