search

Pomax / lib-font

This library adds a new Font() object to the JavaScript toolbox, similar to new Image() for images
MIT License
734 stars 72 forks source link

Unquoted format causing unwanted font behavior and rendering #39

Closed comexpressao closed 5 years ago

comexpressao commented 5 years ago

Adds quotes to eot format. Unquoted format causes unwanted font rendering issues. This adds in the quotes to the format, a la the other formats in same line of code.

Pomax commented 5 years ago

While I appreciate you taking the time to file a PR, the eot format was made obsolete by Microsoft in January of 2016, when it killed off IE8 (it has since also killed off IE9 and IE10. IE11 is the only still supported version of IE). Since Font.js already didn't work for IE8 and below, any code that's still in it for eot should really get removed... if it still made sense to update this library at all.

Effectively, if you're using Font.js for eot in 2019 still, something really weird is going on, and my advice as this library's author is to back away from those eot files, start using woff/woff2, and use a font library that is seeing active development.

What were you using Font.js for?